Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix psalm issues #319

Merged
merged 14 commits into from
Feb 3, 2024
Merged

Fix psalm issues #319

merged 14 commits into from
Feb 3, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 29, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Jan 29, 2024

PR Summary

  • Refinement of checks in DDLQueryBuilder.php
    The criteria used to check for empty strings and null values in various methods of this file were refined. This ensures more accurate detection and handling of these cases.

  • Improved checking mechanism in DMLQueryBuilder.php
    The checks for empty arrays were fine-tuned within two methods. This refinement improves the accuracy in handling scenarios where records are being inserted or updated.

  • Enhanced value checking in Schema.php
    Several methods within this file received modifications to the way they detect and handle empty value cases. By doing so, they should now accurately handle various situations involving extra column info, default column values and json columns. This can increase the stability of operations involving database schemas.

  • Modified pattern matching in DDLQueryBuilder.php and Schema.php
    Two methods, one in each file, had their regular expression pattern matching specifically modified. The adjustment made improves the accuracy of column and index detecting processes. A more accurate detection can help prevent undesired side effects. All these changes refine the way the system works with the database, thus improving the overall system stability and effectiveness.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa3c327) 99.04% compared to head (320d7bf) 99.04%.

❗ Current head 320d7bf differs from pull request most recent head dd20ed0. Consider uploading reports for the commit dd20ed0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #319   +/-   ##
=========================================
  Coverage     99.04%   99.04%           
  Complexity      174      174           
=========================================
  Files            13       13           
  Lines           524      524           
=========================================
  Hits            519      519           
  Misses            5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Jan 30, 2024
src/DDLQueryBuilder.php Outdated Show resolved Hide resolved
src/DDLQueryBuilder.php Outdated Show resolved Hide resolved
@darkdef darkdef added the status:under development Someone is working on a pull request. label Jan 31, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
src/DDLQueryBuilder.php Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@darkdef
Copy link
Contributor

darkdef commented Feb 2, 2024

Move refactoring to other PR

@Tigrov Tigrov removed the status:under development Someone is working on a pull request. label Feb 3, 2024
@Tigrov
Copy link
Member Author

Tigrov commented Feb 3, 2024

Move refactoring to other PR

Done

@vjik vjik merged commit 9fae32a into master Feb 3, 2024
3 checks passed
@vjik vjik deleted the fix-psalm-issues branch February 3, 2024 13:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants