Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix psalm issue (#233) better solution #235

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 20, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #233

@what-the-diff
Copy link

what-the-diff bot commented Aug 20, 2023

PR Summary

  • Updated callback function in Command.php
    The previous coding method in Command.php has been updated for better efficiency. The change replaced a lengthier callback function with a shorthand arrow function in a method called internalExecute. This change aims to enhance readability of our code and make the system work faster.

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (c7b4fc2) 98.29% compared to head (0291cf2) 98.29%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #235      +/-   ##
============================================
- Coverage     98.29%   98.29%   -0.01%     
  Complexity      186      186              
============================================
  Files            16       16              
  Lines           587      585       -2     
============================================
- Hits            577      575       -2     
  Misses           10       10              
Files Changed Coverage Δ
src/Command.php 98.50% <100.00%> (-0.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review August 20, 2023 02:29
@Tigrov Tigrov merged commit 6bb534e into yiisoft:master Aug 20, 2023
@Tigrov Tigrov deleted the fix_psalm_issue branch August 21, 2023 04:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant