Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Command::insertWithReturningPks() #250

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Dec 17, 2023

Related PR:

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues yiisoft/db#792

Copy link

what-the-diff bot commented Dec 17, 2023

PR Summary

  • Enhanced Data Validation
    We have made a significant update to the insertWithReturningPks function within the Command.php file. Specifically, we have added a safeguard that checks for columns returning empty data. This is important because it ensures that the data we're working with is complete, aiding the reliability and accuracy of our operations.

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1ae3f3d) 98.40% compared to head (86eac6c) 98.23%.

Files Patch % Lines
src/Command.php 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
- Coverage     98.40%   98.23%   -0.17%     
- Complexity      175      177       +2     
============================================
  Files            16       16              
  Lines           564      568       +4     
============================================
+ Hits            555      558       +3     
- Misses            9       10       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Alexey Rogachev <arogachev90@gmail.com>
@vjik vjik merged commit 0b28ffb into master Dec 21, 2023
14 of 18 checks passed
@vjik vjik deleted the test-insertWithReturningPks-empty-values branch December 21, 2023 07:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants