Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Realize column factory #864

Merged
merged 13 commits into from
Sep 1, 2024
Merged

Realize column factory #864

merged 13 commits into from
Sep 1, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 13, 2024

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.61%. Comparing base (2f82ef6) to head (783cf5b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Schema/Column/AbstractColumnFactory.php 97.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #864   +/-   ##
=========================================
  Coverage     99.61%   99.61%           
- Complexity     1372     1389   +17     
=========================================
  Files            74       75    +1     
  Lines          3366     3405   +39     
=========================================
+ Hits           3353     3392   +39     
  Misses           13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov requested a review from vjik August 29, 2024 04:24
@Tigrov Tigrov merged commit b0f0dfd into master Sep 1, 2024
57 of 58 checks passed
@Tigrov Tigrov deleted the add-column-factory branch September 1, 2024 07:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants