-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Changed the "level" column in "log" table to be integer again #5
Changed the "level" column in "log" table to be integer again #5
Conversation
Dzhuneyt
commented
Jan 3, 2019
Q | A |
---|---|
Is bugfix? | yes |
New feature? | no |
Breaks BC? | no |
Tests pass? | yes |
Fixed issues | https://github.com/yiisoft/yii-core/issues/132 |
…e it stores integers anyway)
How about making it a single migration? We can do that since there were no package releases yet. |
@samdark what about customers that upgrade from an older version of Yii? They will have the old migration already executed and the column type the wrong one. |
There is no compatibility guarantee between Yii 2.0 and Yii 3.0. But if you think that two separate migrations are better, I'm fine with it. |
Merged. Thanks! |
I have bad experiencing changing old migrations' code for ANY reason in my day job. That's all :) |
@samdark just out of curiousity, now that a lot of functionalities have been moved outside of the yii-core project into their own dedicated projects - will they all have their own CHANGELOG file (I see this one doesn't, for example). |
Yes. After first release. |