Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed CI #42

Merged
merged 13 commits into from
Nov 26, 2021
Merged

Fixed CI #42

merged 13 commits into from
Nov 26, 2021

Conversation

s1lver
Copy link
Member

@s1lver s1lver commented Nov 23, 2021

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues comma-separated list of tickets # fixed by the PR, if any

@s1lver
Copy link
Member Author

s1lver commented Nov 23, 2021

scrutinizer (

@s1lver
Copy link
Member Author

s1lver commented Nov 24, 2021

Снимок экрана 2021-11-24 в 15 38 11

Now it works

@s1lver
Copy link
Member Author

s1lver commented Nov 24, 2021

mutation and static - ok

@vjik
Copy link
Member

vjik commented Nov 24, 2021

Maybe use GITHUB_ENV (docs) how it is done in package template: https://github.com/yiisoft/package-template/blob/master/.github/workflows/build.yml ?

@s1lver
Copy link
Member Author

s1lver commented Nov 24, 2021

In static.yml

(Consider upgrading from Phan 3.2.10 to Phan 4, which has the latest features and bug fixes. This notice can be disabled with PHAN_SUPPRESS_PHP_UPGRADE_NOTICE=1))

@s1lver
Copy link
Member Author

s1lver commented Nov 24, 2021

Maybe use GITHUB_ENV (docs) how it is done in package template: https://github.com/yiisoft/package-template/blob/master/.github/workflows/build.yml ?

can it be like this

@samdark samdark merged commit 837115c into yiisoft:master Nov 26, 2021
@samdark
Copy link
Member

samdark commented Nov 26, 2021

Thank you!

@s1lver s1lver deleted the fix_ci branch March 7, 2023 15:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants