Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Buggy icons #87

Closed
leobasilio opened this issue May 26, 2020 · 9 comments
Closed

Buggy icons #87

leobasilio opened this issue May 26, 2020 · 9 comments
Labels
resolved in dev The issue is resolved in dev branch but not released yet

Comments

@leobasilio
Copy link
Contributor

There's something wrong with the new icons added by 655479d. I'm running MATE 1.20.1 and here's how I see them:

Icon1

The weird thing is that it looks perfect on Inkscape. I tried saving it as plain svg, but it didn't have any effect.

Icon2

@yktoo
Copy link
Owner

yktoo commented May 26, 2020

Weird indeed. I checked both icons with the SVG validator by W3c and the SVG sanitizer, both were happy with the input. The only issue the W3C validator found was the SVG version number that should better be removed.

In Ubuntu they also work perfectly. Does MATE perhaps have known issues with SVG rendering?

@phdzor
Copy link

phdzor commented May 26, 2020

After update today icon has weird shape + since its black you cant even see it.
Screenshot_20200526_104951

Im running Kubuntu 20.04

@yktoo
Copy link
Owner

yktoo commented May 26, 2020

Screenshot_20200526_104951

Im running Kubuntu 20.04

Okay, this one looks like symbolic icons are only supported by Gnome, which changes the icon's colour depending on the theme

@yousefsaif
Copy link

Similar issue on Ubuntu 18.04 LTS (Gnome)

Screenshot from 2020-05-26 15-29-17

@yktoo
Copy link
Owner

yktoo commented May 26, 2020

Okay I've been able to reproduce this crazy rendering on Xubuntu 18.04. Will push an update soon.

yktoo added a commit that referenced this issue May 26, 2020
@yktoo yktoo added the resolved in dev The issue is resolved in dev branch but not released yet label May 26, 2020
@yktoo
Copy link
Owner

yktoo commented May 26, 2020

The garbled appearance was clearly caused by SVGO I used to optimise the icons. This has been undone.

@leobasilio
Copy link
Contributor Author

I have downloaded the new files and it looks fine now.

Captura de tela em 2020-05-26 14-01-40

The color doesn't match, but that's likely due to my custom icons theme. However, it seems that the key color should be #bebebe and not black. This might affect other people.

@yktoo
Copy link
Owner

yktoo commented May 26, 2020

Resolved in 2.3.3.

I will look into fixing the color, I've also opened a question on SO.

@yktoo
Copy link
Owner

yktoo commented Jun 2, 2020

For those interested which SVGO's option exactly breaks the SVGs, it's the convertPathData plugin. The result looks fine when used as:

svgo --disable=convertPathData ...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
resolved in dev The issue is resolved in dev branch but not released yet
Projects
None yet
Development

No branches or pull requests

4 participants