Various Debian packaging fixes #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub releases are "2.2.0", not "2.2.0ubuntu0". There is nothing Ubuntu-specific about this software (I'm using it on Debian). The Debian revision (e.g. 2.2.0-2) can be used for incremental updates to the packaging.
As identified by Debian's lintian.
This is a very old version (shipped with Ubuntu 14.04), so a bit superfluous to depend on it today. Also, this breaks the packaging for Debian systems -- Debian's pulseaudio doesn't have an epoch and thus this dependency is not met (12.2-4 << 1:4.0).
This Python version is ancient so the dependency should be satisfied in every system shipped in the past 7-8 years.
This isn't meaningful - the two versions cannot coexist, a new version also means that the old one will be removed.
These are compiled files that should really be regenerated.
"import gettext" works even without it being installed.
* Switch to https URLs * Add Upstream-Name * Update dates to cover the full span of development so far * Include the full banner of the GPL
Will only work starting from the next release and changelog entry, which should be formatted as "2.2.1-0ubuntu0" rather than "2.2.1ubuntu0-1".
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for indicator-sound-switcher - I've using it for a few years now on a day-to-day basis!
I think I'd like to finally bring it to Debian proper. While contemplating about it (there are still some stuff to figure out), I made a bunch of changes (mostly to
debian/) which I think you would benefit from as well. Hope this helps!