Implementation of Periodic Boundary Condition and Bugfix for plotting on Mac #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement periodic boundary conditions that wraps around the boundary for any selection of xyz plane. Update selection for the possible boundary
|
Thanks for implementing this feature! I will merge this PR now. |
|
As a minor comment, I believe that this implementation is a bit overcomplicated. The curl operation already natively supported the periodic boundary if the padding size would be set to zero at the corresponding side. It might be worthwhile to simplify the implemetation in a future refactoring |
I am planning on adding a Fourier Detector/Diffractive Detector. This will be fixed in the next PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented periodic boundary condition that wraps around the boundaries. Can be applies to any pair of xyz planes.
Bug fix for plotting on Mac that has DPI scaling