Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[OPENY-171] Incorporate all Open Y settings in one place #1352

Merged
merged 17 commits into from
Nov 8, 2018
Merged

[OPENY-171] Incorporate all Open Y settings in one place #1352

merged 17 commits into from
Nov 8, 2018

Conversation

anprok
Copy link
Contributor

@anprok anprok commented Oct 25, 2018

#1045

Steps for review

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer CI.
    CI code sniffer errors
  • All tests are running and there are no failed tests reported by CI.
    Behat test results
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

@anprok anprok requested review from podarok and ddrozdik October 25, 2018 13:06
@anprok anprok self-assigned this Oct 25, 2018
@anprok anprok added PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed labels Oct 25, 2018
@anprok anprok added this to the OpenY 2.0 milestone Oct 25, 2018
@anprok anprok requested a review from AlexNetman October 25, 2018 14:38
@@ -4,7 +4,7 @@ OpenY AddThis module allow you easy add Social icons to any node.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the line above replace OpenY AddThis to the Open Y AddThis

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also found a line in the code Select list of content types where addThis should be enabled by default. and change addThis to the AddThis. Try to find all such places.

@ymcatwincities ymcatwincities deleted a comment from gundevel Oct 25, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Oct 25, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Oct 25, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Oct 25, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Oct 25, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Oct 26, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Oct 26, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Oct 26, 2018
@ddrozdik
Copy link
Contributor

@anprok

  • change OpenY upgrade dashboard to Upgrade dashboard, I have not found this title in the list of your changes.
  • change No conflicts found during OpenY upgrade. -> No conflicts found during Open Y upgrade.
  • /admin/openy/settings/openy_map and /admin/openy/integration/activenet - do not have a description. Please add.
  • Session Instance settings is located under Open Y -> Settings menu but when I click it redirects me to Home -> Administration -> Structure -> Session Instances Listing -> Session Instance settings It should be moved to the new structure.
  • The same thing as above with Groupex Form Cache settings page. also Fix Groupex, should be GroupEx Pro
  • /admin/openy/integration chnage title on this page to Integrations
  • GroupEx Form Cache list opens a wrong URL and breadcrumbs are lost.
  • Change title on the page /admin/openy/extend/list from List to Install so we could have two menu items nstall and Uninstall

@anprok
Copy link
Contributor Author

anprok commented Oct 29, 2018

  • change OpenY upgrade dashboard to Upgrade dashboard, I have not found this title in the list of your changes.

Here place where that menu title changed https://github.com/ymcatwincities/openy/pull/1352/files#diff-f1181ba5d8035c931f7fc8df75171e04R427

@ddrozdik
Copy link
Contributor

@anprok please make sure you have updated all documentation files where old paths are used. For example https://github.com/ymcatwincities/openy/blob/8.x-1.x/docs/Development/Daxko.md
Please check all of them to make sure documentation will have correct URLs.

@anprok
Copy link
Contributor Author

anprok commented Oct 31, 2018

I double-checked routes in documentation, all routes updated

@ymcatwincities ymcatwincities deleted a comment from gundevel Nov 5, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Nov 5, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Nov 5, 2018
@ddrozdik ddrozdik added PR: Code Reviewed Code reviewed. Ready for QA and removed PR: Needs Review Needs someone review ( code ) labels Nov 6, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Nov 7, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Nov 7, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Nov 7, 2018
@ymcatwincities ymcatwincities deleted a comment from ddrozdik Nov 8, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Nov 8, 2018
@ymcatwincities ymcatwincities deleted a comment from gundevel Nov 8, 2018
@gundevel
Copy link
Collaborator

gundevel commented Nov 8, 2018

Build comment file:

Environment Link
Fresh OpenY installation - Rose theme http://openy.cibox.tools/build1137
Fresh OpenY installation - Lily theme http://lily.openy.cibox.tools/build1137
Upgraded(upgrade path) installation http://upgrade.openy.cibox.tools/build1137
Installation process http://install.openy.cibox.tools/build1137/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/1137/

@gundevel
Copy link
Collaborator

gundevel commented Nov 8, 2018

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build1137/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build1137/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build1137/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build1137/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build1137/blogWCAG2AAhtmlcs.txt

@ddrozdik ddrozdik added PR: Tested Manually tested. Green light for merging and removed PR: Needs Testing Manual testing is needed labels Nov 8, 2018
@ddrozdik ddrozdik merged commit 469b394 into ymcatwincities:decoupling Nov 8, 2018
@anprok anprok deleted the OPENY-171 branch January 17, 2019 10:01
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
PR: Code Reviewed Code reviewed. Ready for QA PR: Tested Manually tested. Green light for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants