[OPENY-1375] Search icon and form removed from Carnation theme 8.x 2.x

[afi13]

Issue #1375

Steps for review for new installations

• Install Carnation theme and set as the default theme.
• Go to /admin/appearance/settings/openy_carnation and make sure 'Display the search form' setting is enabled by default.
• Make sure search icon anf form are displayed for desktop and mobile.
• Go to /admin/appearance/settings/openy_carnation and disable 'Display the search form' .
• Make sure search icon and form are hidden for desktops.
• Make sure search icon and form are hidden for mobile.
• There no any visible FE regressions.

Steps for review of upgrade path

• Make sure 'Display the search form' setting is enabled after db updates.
• Make sure search icon and form are displayed for desktop and mobile.
• Go to /admin/appearance/settings/openy_carnation and disable 'Display the search form' .
• Make sure search icon and form are hidden for desktops.
• Make sure search icon and form are hidden for mobile.
• There no any visible FE regressions.

General checks

• All coding styles are fulfilled and there are no any issues reported by CodeSniffer CI.
  
• All tests are running and there are no failed tests reported by CI.
  
• Documentation has been updated according to PR changes.
• Steps for review have been provided according to PR changes.
  
• Make sure you've provided all necessary hook_update_N to support upgrade path.
• Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
  
• If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

[ddrozdik]

retest this please

[gundevel]

Build comment file:

Environment	Link
Fresh OpenY installation - Rose theme	http://openy.cibox.tools/build1187
Fresh OpenY installation - Lily theme	http://lily.openy.cibox.tools/build1187
Upgraded(upgrade path) installation	http://upgrade.openy.cibox.tools/build1187
Installation process	http://install.openy.cibox.tools/build1187/install.php

---

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/1187/

[gundevel]

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build1187/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build1187/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build1187/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build1187/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build1187/blogWCAG2AAhtmlcs.txt