-
Notifications
You must be signed in to change notification settings - Fork 110
[OPENY-237] Remove blazy for render icon #1408
Conversation
DeepCode analyzed this pull request. |
Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution. |
3bafe79
to
df21458
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to update core.entity_view_display.media.image.icon.yml config
f27341e
to
c010aa4
Compare
c010aa4
to
c1fdfac
Compare
modules/openy_features/openy_media/modules/openy_media_image/openy_media_image.install
Outdated
Show resolved
Hide resolved
0c11996
to
88a86ff
Compare
Tested this patch on YGS project, works fine |
retest this please |
Build comment file:
Test PASSed. |
Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build1198/frontWCAG2AAhtmlcs.txt |
Issue details:
When used Grid columns paragraph type and upload icons, they are rendered with Blazy. Blazy added custom inline styles and we can see big space after icons.
I changed entity view display in media to
Image
.Steps for review
One column
value in Layout of Landing pageGrid columns
paragraph to Content Area region3 items per row
value in Style