Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[OPENY-237] Remove blazy for render icon #1408

Merged
merged 2 commits into from
Dec 21, 2018

Conversation

miroslav-lee
Copy link
Contributor

@miroslav-lee miroslav-lee commented Dec 18, 2018

Issue details:

When used Grid columns paragraph type and upload icons, they are rendered with Blazy. Blazy added custom inline styles and we can see big space after icons.
before
I changed entity view display in media to Image.
after

Steps for review

  • Go to /node/add/landing_page
  • Set One column value in Layout of Landing page
  • Add Grid columns paragraph to Content Area region
  • Set 3 items per row value in Style
  • Add grid columns, and in last column upload this icon Icon
  • Save this page
  • You shouldn't see space as the picture.
    after

@ghost
Copy link

ghost commented Dec 18, 2018

DeepCode analyzed this pull request.
There are no new issues.

@gundevel
Copy link
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@miroslav-lee miroslav-lee self-assigned this Dec 18, 2018
@miroslav-lee miroslav-lee added Status: Needs review Needs reviewer attention. Type: Bug Bug. Something is not working as intended. PR: Needs Testing Manual testing is needed labels Dec 18, 2018
@miroslav-lee miroslav-lee added this to the OpenY 2.0 milestone Dec 18, 2018
@hamrant hamrant added PR: Needs Work Unfinished task. Issues still there and removed PR: Needs Testing Manual testing is needed Status: Needs review Needs reviewer attention. labels Dec 18, 2018
Copy link
Contributor

@hamrant hamrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update core.entity_view_display.media.image.icon.yml config

openy.install Outdated Show resolved Hide resolved
@hamrant hamrant added PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed and removed PR: Needs Work Unfinished task. Issues still there labels Dec 19, 2018
@hamrant
Copy link
Contributor

hamrant commented Dec 20, 2018

Tested this patch on YGS project, works fine

@hamrant hamrant added PR: Code Reviewed Code reviewed. Ready for QA PR: Tested Manually tested. Green light for merging and removed PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed labels Dec 20, 2018
@ddrozdik
Copy link
Contributor

retest this please

@gundevel
Copy link
Collaborator

Build comment file:

Environment Link
Fresh OpenY installation - Rose theme http://openy.cibox.tools/build1198
Fresh OpenY installation - Lily theme http://lily.openy.cibox.tools/build1198
Upgraded(upgrade path) installation http://upgrade.openy.cibox.tools/build1198
Installation process http://install.openy.cibox.tools/build1198/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/1198/

@gundevel
Copy link
Collaborator

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build1198/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build1198/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build1198/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build1198/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build1198/blogWCAG2AAhtmlcs.txt

@podarok podarok merged commit 678de64 into ymcatwincities:8.x-2.x Dec 21, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
PR: Code Reviewed Code reviewed. Ready for QA PR: Tested Manually tested. Green light for merging Type: Bug Bug. Something is not working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants