main_process: close the channel receivers. #1936
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like libcontainer (at least when used from runwasi) is leaking three FDs for every container creation. This becomes a problem in Wasm use cases, where a single process may spawn a large number of Wasm containers. The
lsof
output looks like this:This PR closes the receiving ends for the Youki sockets. The number of open sockets goes down and I'm able to run over a thousand containers from one process. I'm not familiar enough with Youki to be certain that this doesn't have any side effects, though.