-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update dependencies described in docs #1960
Conversation
Hey @l0rem1psum Thanks for this PR! Can you please sign your commit for DCO? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1960 +/- ##
=======================================
Coverage 65.01% 65.02%
=======================================
Files 129 129
Lines 14731 14731
=======================================
+ Hits 9578 9579 +1
+ Misses 5153 5152 -1 |
b786825
to
18f6965
Compare
@YJDoc2 Thanks! The previous commit was already signed off. Let me set up a Ubuntu-based distro to verify it before I make further commits. BTW, do you have any recommended VirtualBox images in mind for me to test? Or I can just use any one? |
@l0rem1psum The docs states in general 'Debian and Ubuntu based distro' ; so any recent version of those should be fine. |
Tested with
OS Release:
I will update and tidy up the docs accordingly. |
Signed-off-by: l0rem1psum <iswenxuan@gmail.com>
…changes Signed-off-by: l0rem1psum <iswenxuan@gmail.com>
18f6965
to
830e4af
Compare
Docs and README are all updated. In the first commit, I wrongly put Also, looks like the |
Signed-off-by: l0rem1psum <iswenxuan@gmail.com>
Hey, why are these added in vagrantfile |
Without them, it's not possible to run unit tests. Also, it was mentioned in the docs but not in the Vagrantfile. Thought it would make more sense to make things consistent. |
Oh yes, we must have missed while updating 😓 Thanks a lot for updation. Looks good to me, I'll merge this once CI is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Thanks a lot for your contribution!
While setting up the environment, I encountered a few dependency issues that I hope to solve in this pull request.
wasmedge-sys
requireswget
, which is not found in thefedora/33-cloud-base
VirtualBox image. See: https://github.com/WasmEdge/WasmEdge/blob/master/bindings/rust/wasmedge-sys/build.rs#L408openssl-sys
requires the host system to have the OpenSSL library, which is also not found infedora/33-cloud-base
.