Do not try to acquire capabilities we are not allowed to #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2000 +/- ##
==========================================
- Coverage 65.28% 65.26% -0.02%
==========================================
Files 129 129
Lines 14784 14802 +18
==========================================
+ Hits 9651 9661 +10
- Misses 5133 5141 +8 |
jprendes
changed the title
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
yihuaf
approved these changes
Jun 6, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
reset_effectivetries to acquire all know capabilities from a hardcoded list.According to https://man7.org/linux/man-pages/man7/capabilities.7.html only capabilities in the
permittedset can be acquired.Trying to acquire a capability beyond those in the
permittedset will result inEPERM(see https://man7.org/linux/man-pages/man2/capset.2.html).This change modifies
reset_effectiveso that it only acquires the capabilities in thepermittedset.This change is intended to fix #1999.