-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add one label to generate release notes #2122
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2122 +/- ##
==========================================
- Coverage 64.82% 64.81% -0.01%
==========================================
Files 129 129
Lines 14768 14769 +1
==========================================
Hits 9573 9573
- Misses 5195 5196 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ❇️ This is amazing!
We should also add the auto-merge PR workflow to add label dependabot on the PRs, else their workflow will fail |
Signed-off-by: utam0k <k0ma@utam0k.jp>
Is there a tag or a way to exclude small fixes and trivial changes? Or we should lump these under the |
Maybe having a |
I thought about |
I think the way that is there currently in PR for grouping from labels is fine, I was thinking to add |
@YJDoc2 I think this case you said works fine using |
I think |
Now I'm not sure either. In the end it is our call , so we can use cleanup for the typos and minor fixes as k8s does ; or we can allow a PR to be without label. I think just for the sake of having all important PRs in the release notes and not missing them due to missing label ; as well as for reducing the task of manual writing of release notes ; I'll suggest we go ahead for now with the cleanup label approach, and if it has any difficulties in future, we can come back and re-discuss . wdyt @yihuaf ? |
@YJDoc2 Thanks for your understanding. |
Once, I will merge this PR, but I welcome your feedback. |
cleanup is fine with me. |
Make the heaviest of release tasks, the generation of release notes, much easier.