Use syscall type to delay the creation of syscall struct. #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuaf
force-pushed
the
yihuaf/syscall_type
branch
from
9d52304 to
ed57fef
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2155 +/- ##
=======================================
Coverage 64.82% 64.83%
=======================================
Files 129 129
Lines 14769 14773 +4
=======================================
+ Hits 9574 9578 +4
Misses 5195 5195 |
yihuaf
force-pushed
the
yihuaf/syscall_type
branch
2 times, most recently
from
42e185d to
fba8c41
Compare
Signed-off-by: yihuaf <yihuaf@unkies.org>
yihuaf
force-pushed
the
yihuaf/syscall_type
branch
from
fba8c41 to
fb807b4
Compare
yihuaf
changed the title
utam0k
added
breaking change
kind/cleanup
utam0k
approved these changes
Jul 14, 2023
|
@yihuaf |
No worries :) More incoming. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling out changes from #2121
Included #2150 to disable musl test. Will rebase once #2150 is merged.
Details:
In this PR we propose to store a SyscallType instead of syscall structure. The syscall structure itself is am empty struct, so we can delay the creation. In this way, we don't have to pass this reference through the fork/clone boundary. The eventual goal is not to use lifetime reference in the
container_argsstructure.