Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add io priority #2164

Merged
merged 1 commit into from
Jul 17, 2023
Merged

add io priority #2164

merged 1 commit into from
Jul 17, 2023

Conversation

lengrongfu
Copy link
Collaborator

@lengrongfu lengrongfu commented Jul 12, 2023

issue: #2065

kind/featur

@codecov-commenter
Copy link

Codecov Report

Merging #2164 (bc91c63) into main (d7e4a04) will decrease coverage by 0.10%.
The diff coverage is 51.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2164      +/-   ##
==========================================
- Coverage   64.82%   64.73%   -0.10%     
==========================================
  Files         129      129              
  Lines       14769    14875     +106     
==========================================
+ Hits         9574     9629      +55     
- Misses       5195     5246      +51     

@lengrongfu lengrongfu force-pushed the feat/add-io-priority branch 2 times, most recently from 0e786f1 to bc17333 Compare July 12, 2023 07:55
Copy link
Collaborator

@yihuaf yihuaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm. Small nits around error types.

@lengrongfu lengrongfu force-pushed the feat/add-io-priority branch from bc17333 to 61e1487 Compare July 13, 2023 09:27
Copy link
Collaborator

@yihuaf yihuaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed youki-dev/oci-spec-rs#137 to cut a new release. After that I will help to get this merged.

@yihuaf
Copy link
Collaborator

yihuaf commented Jul 15, 2023

@lengrongfu v0.6.2 for oci-spec-rs is pushed.

@lengrongfu lengrongfu force-pushed the feat/add-io-priority branch 3 times, most recently from ca1b8df to 9f92f8f Compare July 17, 2023 04:28
@lengrongfu
Copy link
Collaborator Author

image

This error is very strange, do you have any ideas. @yihuaf

@yihuaf
Copy link
Collaborator

yihuaf commented Jul 17, 2023

image This error is very strange, do you have any ideas. @yihuaf

Yes, the interface was changes with an previous, so you would have to rebase. I can try to fix this tomorrow if you are not sure.

Signed-off-by: lengrongfu <1275177125@qq.com>
@lengrongfu lengrongfu force-pushed the feat/add-io-priority branch from 9f92f8f to f2c3ff4 Compare July 17, 2023 15:15
@yihuaf yihuaf merged commit f6859f0 into youki-dev:main Jul 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants