Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test(integration_test): port 'runtime-tools/validation/linux_sysctl' #2527

Merged
merged 1 commit into from
Nov 13, 2023
Merged

test(integration_test): port 'runtime-tools/validation/linux_sysctl' #2527

merged 1 commit into from
Nov 13, 2023

Conversation

xiaoyang-sde
Copy link

@xiaoyang-sde xiaoyang-sde commented Nov 13, 2023 •
edited
Loading

#361

This pull request ports the runtime-tools/validation/linux_sysctl test case to tests/integration_test/src/tests/sysctl/mod.rs.

test(integration_test): port 'runtime-tools/validation/linux_sysctl'
dac5f30 
Signed-off-by: Xiaoyang Liu <siujoeng.lau@gmail.com>
utam0k
utam0k reviewed Nov 13, 2023
View reviewed changes
tests/runtimetest/src/tests.rs
@@ -267,3 +267,25 @@ pub fn validate_mounts_recursive(spec: &Spec) {
}
}
}

pub fn validate_sysctl(spec: &Spec) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@codecov-commenter
Copy link

Codecov Report

Merging #2527 (dac5f30) into main (9ae5660) will not change coverage.
Report is 7 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2527   +/-   ##
=======================================
  Coverage   65.87%   65.87%           
=======================================
  Files         133      133           
  Lines       16868    16868           
=======================================
  Hits        11111    11111           
  Misses       5757     5757

utam0k
utam0k reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your PR ;)

I have one question. It is simply a questionnaire. Have you read this documentation to create this integration test?
https://containers.github.io/youki/developer/e2e/rust_oci_test.html

@utam0k utam0k merged commit 7b4160a into youki-dev:main Nov 13, 2023
@utam0k utam0k mentioned this pull request Nov 13, 2023
Open
60 tasks
@xiaoyang-sde xiaoyang-sde deleted the linux_sysctl branch November 13, 2023 18:43
@xiaoyang-sde
Copy link
Author

xiaoyang-sde commented Nov 13, 2023 •
edited
Loading

I appreciate your PR ;)

I have one question. It is simply a questionnaire. Have you read this documentation to create this integration test? https://containers.github.io/youki/developer/e2e/rust_oci_test.html

No problem! 😉
Yeah I read these docs before writing the code.

@utam0k
Copy link
Member

utam0k commented Nov 14, 2023

Yeah I read these docs before writing the code.

@xiaoyang-sde Thanks 😍 If you find what we improve them, please send a PR or create an issue 🙏

This was referenced Dec 17, 2023
Merged
Merged
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@utam0k utam0k utam0k approved these changes

Assignees
No one assigned
Labels
kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoyang-sde @codecov-commenter @utam0k