Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add docker-in-docker e2e test #2645

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

jprendes
Copy link
Contributor

This PR adds tests to lock the behavior introduced by #2532.
It tests that youki can be used in docker-in-docker with both cgroups v1 (through Ubuntu 20.04) and v2 (through Ubuntu 22.04).

@jprendes jprendes force-pushed the test/e2e/docker-in-docker branch from 032db70 to 933ee42 Compare January 19, 2024 16:03
@jprendes jprendes requested a review from a team January 19, 2024 16:11
@jprendes jprendes force-pushed the test/e2e/docker-in-docker branch from 933ee42 to 9e4b767 Compare January 19, 2024 21:45
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
@jprendes jprendes force-pushed the test/e2e/docker-in-docker branch from 9e4b767 to 7d17e08 Compare January 19, 2024 21:49
@codecov-commenter
Copy link

Codecov Report

Merging #2645 (7d17e08) into main (8db3599) will decrease coverage by 0.02%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2645      +/-   ##
==========================================
- Coverage   65.89%   65.88%   -0.02%     
==========================================
  Files         133      133              
  Lines       16819    16819              
==========================================
- Hits        11083    11081       -2     
- Misses       5736     5738       +2     

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@utam0k utam0k merged commit 3f08ae7 into youki-dev:main Jan 20, 2024
28 checks passed
@github-actions github-actions bot mentioned this pull request Jan 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants