move macro define youki_version to use before #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rongfu.leng <lenronfu@gmail.com>
lengrongfu
force-pushed
the
fix/move-youki_version
branch
from
46e0fda to
bdf8db4
Compare
|
@YJDoc2 Can you help me review this PR? thanks ~ |
YJDoc2
added
the
kind/cleanup
YJDoc2
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Ideally this should be fixed in rust rover, as this seems to work in other places like vs code and nvim lsp. Anyways, not a big change, only definition is moved around in same file, so acceptable.
Also apologies for the delay, I saw failing CI and thought it was an issue on the code side, when actually it was PR label problem.
Merged
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2812