Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update README.md #2822

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Update README.md #2822

merged 2 commits into from
Jun 27, 2024

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Jun 20, 2024

No description provided.

Signed-off-by: utam0k <k0ma@utam0k.jp>
@utam0k utam0k requested a review from a team June 20, 2024 13:03
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, a couple of minor questions

Comment on lines -29 to -32
# About the name

youki is pronounced as /joʊki/ or yoh-key.
youki is named after the Japanese word 'youki', which means 'a container'. In Japanese language, youki also means 'cheerful', 'merry', or 'hilarious'.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep this part, even though not strictly necessary.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay!

Comment on lines -325 to -327
# Community

We also have an active [Discord](https://discord.gg/h7R3HgWUct) if you'd like to come and chat with us.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add the discord link in the docs contributing section, I don't think it is there right now.

Copy link
Collaborator

@yihuaf yihuaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: utam0k <k0ma@utam0k.jp>
@utam0k utam0k enabled auto-merge (squash) June 26, 2024 13:19
@utam0k
Copy link
Member Author

utam0k commented Jun 27, 2024

Since this PR only changed README.md, the CI has never started. I'll merge this PR with my privilege.

@utam0k utam0k disabled auto-merge June 27, 2024 06:05
@utam0k utam0k merged commit 11ca60d into youki-dev:main Jun 27, 2024
24 checks passed
@github-actions github-actions bot mentioned this pull request Jun 25, 2024
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants