Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Install nightly for running linter inside devcontainer #2845

Merged

Conversation

musaprg
Copy link
Contributor

@musaprg musaprg commented Jul 7, 2024

Nightly release is required for running formatter and linter as rustfmt.toml uses unstable features, however devcontainer only installs stable release. This PR adds a line to the devcontainer's Dockerfile to install nightly along with stable release.

Signed-off-by: Kotaro Inoue <k.musaino@gmail.com>
@YJDoc2 YJDoc2 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 9, 2024
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@YJDoc2 YJDoc2 merged commit a239031 into youki-dev:main Jul 9, 2024
29 of 30 checks passed
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
@musaprg musaprg deleted the install-nightly-for-linter-in-devcontainer branch July 9, 2024 07:28
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants