Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add delete test #3082

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sou1118
Copy link

@sou1118 sou1118 commented Feb 25, 2025

Description

Added integration tests for the container delete operation to verify Youki's behavior in various container states. The tests check four scenarios:

  1. Deleting a non-existent container (fails as expected)
  2. Deleting a container in "created" state (succeeds as expected)
  3. Deleting a container in "running" state (fails as expected)
  4. Deleting a container in "stopped" state (succeeds as expected)

These tests improve our coverage of container lifecycle operations and ensure consistent behavior across Youki releases.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other (please describe):

Testing

  • Added new unit tests
  • Added new integration tests
  • Ran existing test suite
  • Tested manually (ran the new tests using the test framework)

Related Issues

#361

Additional Context

The tests verify that Youki properly handles container deletion across different container states. Each test includes appropriate cleanup steps to ensure no resources are left behind after test execution.

@sou1118 sou1118 force-pushed the feature/add-delete-test branch from a1959fc to 7bdeebd Compare February 25, 2025 06:23
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Feb 25, 2025

Hey, can you rebase on main? I think that will fix the failing CI.

@sou1118 sou1118 force-pushed the feature/add-delete-test branch from 7bdeebd to d9576c2 Compare February 25, 2025 11:55
@sou1118
Copy link
Author

sou1118 commented Feb 25, 2025

Hi! I did rebase on main!

Signed-off-by: sou1118 <hello@kattyan.dev>
@sou1118 sou1118 force-pushed the feature/add-delete-test branch from d9576c2 to 27cfbe4 Compare February 25, 2025 13:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants