Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade direct dep rand to 0.9.0 #3083

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Upgrade direct dep rand to 0.9.0 #3083

merged 3 commits into from
Feb 25, 2025

Conversation

YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Feb 25, 2025

Description

This takes over from #3061, and fixes the lint and other compilation issues.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other : Dep update

Testing

  • Added new unit tests
  • Added new integration tests
  • Ran existing test suite
  • Tested manually (please provide steps)

Related Issues

N/A , just dep update

Additional Context

N/A

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
@YJDoc2 YJDoc2 added the dependencies Pull requests that update a dependency file label Feb 25, 2025
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
Copy link
Collaborator Author

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going ahead and merging this, as it is sort-of blocking other dep update prs, which are piling up. The main changes are -

  1. upgrade rand crate to 0.9.0 ; the only changes we are affected by are naming changes, eg thread_rng->rng , gen_range->random_range etc. The behavior should be still the same.
  2. Changed CI for cargo-machete due to Why does Github action installs the latest version? bnjbvr/cargo-machete#156 ; the only effect is instead of upstream action, we use taiki-e to install and run. Otherwise no difference.

Going ahead and merging as all CI passes. cc @youki-dev/youki

@YJDoc2 YJDoc2 merged commit 096adf7 into youki-dev:main Feb 25, 2025
27 checks passed
@YJDoc2 YJDoc2 deleted the deps/rand branch February 25, 2025 09:34
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant