update rust version to 1.85.0 #3085
Open
+49
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
YJDoc2
added
the
kind/cleanup
YJDoc2
commented
Feb 25, 2025
Comment on lines
+226
to
+229
| // given that start has failed, we can be pretty sure that create has either failed | ||
| // or completed already, so we wait on it so it does not become a zombie process | ||
| let _ = create_process.wait_with_output(); | ||
| return TestResult::Failed(anyhow!("container start failed : {:?}", e)); |
There was a problem hiding this comment.
I would like someone to take another look at this, the clippy error was that in the early return codepath here, we do not wait on the create process, hence it can become a zombie process. Hence I added a wait here with assumption that if the start_container has failed, we can be fairly certain that the original create has also errored or has already exited.
However, would like someone else to confirm the logic.
There was a problem hiding this comment.
Why don't we create a different PR for only this part? This could be an important change.
There was a problem hiding this comment.
Hey, ok, I'll create a separate PR just for this change, and once that is resolved I can rebase this PR.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates rust version to latest stable 1.85.0. This also aligns with the new rust editions, and some deps like wasmtime require us to update our rust version to 1.82+ anyways.
The code changes are simply fixes suggested by clippy.
NOTE: it seems cross-rs has not yet caught up with latest rust version, so it is failing to compile. Will need to wait for them, or use pre-compiled binaries to avoid this.
Type of Change
Testing
Related Issues
N/A
Additional Context
Even though the fix suggestions by clippy should be correct, we should have another look for confirmation and sanity checks.