Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

revert asynchronous devices mounting. #41

Merged
merged 1 commit into from
May 28, 2021
Merged

revert asynchronous devices mounting. #41

merged 1 commit into from
May 28, 2021

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented May 27, 2021

I had previously tried to mount asynchronously, but this made our integration tests unstable.
I reverted it once, but it was still there, so I deleted it.

@utam0k utam0k requested a review from tsturzl May 27, 2021 23:39
@utam0k
Copy link
Member Author

utam0k commented May 27, 2021

@tsturzl You may not have read much of the code around here, but please give it a light review if you like.

Copy link
Collaborator

@tsturzl tsturzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm curious what might have been causing the issues. Any ideas? I've noticed in the async work I'm doing that I have had to make sure I call sync on the writer. I wouldn't have thought I'd have to do this when writing to a virtual filesystem, so maybe there is something not so obvious happening?

@utam0k
Copy link
Member Author

utam0k commented May 28, 2021

@tsturzl
When I ran it with docker in my local, it worked normally, but I could only find out that it failed in the integration test.
If you have any problems with cgroups asynchronous support, I should seriously look into it.

@utam0k utam0k merged commit 37243cd into main May 28, 2021
@utam0k utam0k deleted the revert-async-mounts branch May 28, 2021 06:18
nimrodshn pushed a commit to nimrodshn/youki that referenced this pull request May 29, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants