Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ready for integration test for the exec command. #622

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Jan 19, 2022

youki's exec command is now broken 😭
cc: @Furisto

I've checked that this pr works fine using runc.

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this is a very good idea to add an exec test! I don't think the original oci-tests had exec separately tests, which is why we might have forgotten to add this originally, but definitely a needed addition 👍

I have added a couple of comments, please take a look at them :)

@utam0k
Copy link
Member Author

utam0k commented Jan 24, 2022

@YJDoc2 PTAL

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jan 24, 2022

Hey, This is great, we can merge this now 👍
The CI seems to be failing due to DCO app, but I'm not sure when and why did we enable this for the repo. 🤔

@utam0k utam0k merged commit e86f2b4 into youki-dev:main Jan 28, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants