Use the libseccomp-rs/libseccomp-rs crate instead of youki original libseccomp-rs. #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utam0k
force-pushed
the
feature/remove-original-libseccomp
branch
from
6199810 to
1dd3fa7
Compare
|
Thanks to @ManaSugi, the author of libseccomp-rs. If you have something(e.g. not ready for production yet) to say, please let me know. |
Codecov Report
@@ Coverage Diff @@
## main #741 +/- ##
========================================
Coverage 72.23% 72.24%
========================================
Files 87 86 -1
Lines 11912 11756 -156
========================================
- Hits 8605 8493 -112
+ Misses 3307 3263 -44 |
utam0k
force-pushed
the
feature/remove-original-libseccomp
branch
from
c8d7e53 to
2b0f1f6
Compare
saschagrunert
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Awesome, this removes duplication. @utam0k to you wanna fix the open suggestion, otherwise LGTM
ManaSugi
reviewed
Feb 28, 2022
saschagrunert
approved these changes
Mar 2, 2022
yihuaf
approved these changes
Mar 2, 2022
…ibseccomp-rs. Signed-off-by: utam0k <k0ma@utam0k.jp>
Signed-off-by: utam0k <k0ma@utam0k.jp>
Co-authored-by: Manabu Sugimoto <66765615+ManaSugi@users.noreply.github.com>
utam0k
force-pushed
the
feature/remove-original-libseccomp
branch
from
7daed7a to
5916ff3
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this proposal acceptable to you?
https://github.com/libseccomp-rs/libseccomp-rs