Skip to content

Commit

Permalink
Just use latest windows-2022 runner without specifying toolset
Browse files Browse the repository at this point in the history
  • Loading branch information
EddieEldridge committed Feb 28, 2025
1 parent 7cf3de1 commit 137d8a4
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/build-and-release-eop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ jobs:
# This job is used to build EOP
# It runs on every commit pushed to GitHub
build-eop:
runs-on: windows-2019
# The C++ version can change, we do not have control over it. EOP should generally be able to compile with the latest
# Microsoft Visual C++ 2022 Minimum Runtime
# https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md#microsoft-visual-c
runs-on: windows-2022

# Steps
steps:
Expand All @@ -33,7 +36,7 @@ jobs:
# This job is used to update the online documentation
# It requires a commit message beginning with 'Docs' to run
update-docs:
runs-on: windows-2019
runs-on: windows-2022

if: "startsWith(github.event.head_commit.message, 'Docs:')"
steps:
Expand All @@ -51,7 +54,7 @@ jobs:
# This job is used to release EOP to GitHub and update the documentation
# It requires a commit message beginning with 'Release' to run
release-eop:
runs-on: windows-2019
runs-on: windows-2022

# If the latest commit message starts with 'Release', update docs and issue a release on GitHub
if: "startsWith(github.event.head_commit.message, 'Release:')"
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/composite-actions/build-eop/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ description: 'Builds the Project (Restores Cache, Setups Env and Builds Project)
runs:
using: "composite"
steps:
# Use msvc-dev building
# Use msvc-dev building
# The C++ version can change, we do not have control over it. EOP should generally be able to compile with the latest
# Microsoft Visual C++ 2022 Minimum Runtime
# https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md#microsoft-visual-c
- uses: ilammy/msvc-dev-cmd@v1
# with:
# toolset: "14.42"

- name: Show checked out files
run: ls -l
Expand Down

0 comments on commit 137d8a4

Please # to comment.