implement edge dictionary injectable for testing process #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404
This PR implements injectable edge dictionary as a table declaration on testing process like simulator configuration.
Configuration
We will define the
config.testing.edge_dictionary
as the same asconfig.simulator.edge_dictionary
.Once I thought that we can use
config.simulator.edge_dictionary
also in the testing process but I decided that the simulator and testing should work independenctly so I divided configuration.Changes
And I added a tiny improvement, We only can override dictionary items for existing table, but now we can also inject the edge dictionary as a new table declaration.
This makes the user can inject any edge dictionary even not defined in main VCL (or Fastly Service) - it's better performace for testing because we don't need to fetch the remote edge dictionary - but need to take care that the main VCL will have dependency to the injected dictionary.
Please make sure the tests should pass without dictionary injection before deployments.