DEP: drop support for matplotlib<3.5 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
drop_mpl_34
branch
from
407b303 to
f33e733
Compare
neutrinoceros
force-pushed
the
drop_mpl_34
branch
from
f33e733 to
df53f4b
Compare
neutrinoceros
force-pushed
the
drop_mpl_34
branch
from
df53f4b to
902d540
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should be okay now that yt (dev) requires matplotlib>=3.5 (yt-project/yt#4521)
Also avoid unnecessary copies (
matplotlib.colormaps.registeralways copies inputs, so we don't need an extra copy to safely modify a colormap). This makes cmyt finally negligible in terms of startup overhead inimport yt(going from 4% to <0.8%).