REL: backports for yt 4.0.4 #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG: fix compatibility with gadget 2 files using '*.gad.*' template
neutrinoceros
commented
May 6, 2022
| @@ -15,8 +15,6 @@ | |||
|
|
|||
| install_ccompiler() | |||
|
|
|||
| VERSION = "4.0.3" | |||
There was a problem hiding this comment.
this wasn't used anywhere anymore
There was a problem hiding this comment.
And I think when we released 4.0.3 we talked about removing it!
neutrinoceros
force-pushed
the
manual_bp_yt4.0.4
branch
from
eb1f6df to
e687f95
Compare
neutrinoceros
force-pushed
the
manual_bp_yt4.0.4
branch
from
e687f95 to
1803f6e
Compare
neutrinoceros
added
bug
infrastructure
|
@matthewturk I took the liberty to setup a small milestone. This PR should contain everything worth backporting since 4.0.3 |
|
Awesome. I'll look it over tomorrow morning and merge it if it's good. (Still marked as draft!) |
|
Yup, keeping as a draft to signal that corresponding PRs to main should be dealt with first :) |
|
Keeping as a draft for a couple days more while we wait for a critical upstream fix from pip. |
BLD: fix a build error on Windows
neutrinoceros
force-pushed
the
manual_bp_yt4.0.4
branch
from
1803f6e to
8231659
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Mainly motivated by #3911.
contents
Opening as a draft, will open for review when the back ported PRs are actually merged.