Separate CHYT init options into makeDefault and createPublicClique #347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
makeDefault
parameter in the CHYT spec has two meanings. First, it adds--make-default
to the init script parameters, which causes the uploaded image to be marked as default for cliques. Second, it controls whetherinitChPublicJob
is run. These effects are completely unrelated and one does not always want both of them. This PR moves the second effect under its own optioncreatePublicClique
.