Skip to content

Commit

Permalink
feat: added a new query button [#238]
Browse files Browse the repository at this point in the history
  • Loading branch information
vitshev committed Jan 12, 2024
1 parent 03bb66c commit 1f4fe1b
Show file tree
Hide file tree
Showing 16 changed files with 304 additions and 50 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,9 @@ $TOOLBAR_COMPONENT_HEIGHT: 48px;
&_shrinkable {
flex-shrink: 1;
}

&_margin-right_half {
margin-right: 12px;
}
}
}
28 changes: 18 additions & 10 deletions packages/ui/src/ui/components/WithStickyToolbar/Toolbar/Toolbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const ToolbarItemPropTypes = {
wrapperClassName: PropTypes.string,
growable: PropTypes.bool,
shrinkable: PropTypes.bool,
marginRight: PropTypes.string,
};

interface Props {
Expand All @@ -22,6 +23,7 @@ interface Props {
wrapperClassName?: string;
growable?: boolean;
shrinkable?: boolean;
marginRight?: 'half';
}>;
children?: React.ReactNode;
}
Expand All @@ -44,15 +46,21 @@ export class Toolbar extends React.Component<Props> {

renderItems() {
const {itemsToWrap = []} = this.props;
return itemsToWrap.map(({name, node, growable, shrinkable, wrapperClassName}, index) => {
return node ? (
<div
key={name || index}
className={block('item', {name, growable, shrinkable}, wrapperClassName)}
>
{node}
</div>
) : null;
});
return itemsToWrap.map(
({name, node, growable, shrinkable, wrapperClassName, marginRight}, index) => {
return node ? (
<div
key={name || index}
className={block(
'item',
{name, growable, shrinkable, 'margin-right': marginRight},
wrapperClassName,
)}
>
{node}
</div>
) : null;
},
);
}
}
28 changes: 28 additions & 0 deletions packages/ui/src/ui/hooks/use-promise-waiter.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import * as React from 'react';

class PromiseWaiter<Data> {
promise: Promise<Data | undefined> | undefined = undefined;
resolve = (_d?: Data) => {};
reject = (_e?: Error) => {};

create() {
this.promise = new Promise<Data | undefined>((resolve, reject) => {
this.resolve = (d) => {
resolve(d);
this.promise = undefined;
this.resolve = () => {};
};
this.reject = (e) => {
reject(e);
this.promise = undefined;
this.reject = () => {};
};
});

return this.promise;
}
}

export function usePromiseWaiter<Data>() {
return React.useRef(new PromiseWaiter<Data>()).current;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
import * as React from 'react';
import {useState} from 'react';
import {useSelector} from 'react-redux';
import {Button} from '@gravity-ui/uikit';
import Icon from '../../../components/Icon/Icon';
import {usePromiseWaiter} from '../../../hooks/use-promise-waiter';
import Modal from '../../../components/Modal/Modal';
import {isQueryDraftEditted} from '../module/query/selectors';

const NewQueryPromt = (props: {cancel: () => void; confirm: () => void; visible: boolean}) => {
return (
<Modal
title="New query"
content="All the changes will be lost. Are you sure you want to reset query?"
onCancel={props.cancel}
onConfirm={props.confirm}
onOutsideClick={props.cancel}
visible={props.visible}
/>
);
};

export const NewQueryButton = ({onClick}: {onClick: () => void}) => {
const waiter = usePromiseWaiter();
const dirtyQuery = useSelector(isQueryDraftEditted);
const [visible, setVisible] = useState(false);

const handleClick = () => {
if (dirtyQuery) {
setVisible(true);

waiter
.create()
.then(() => {
onClick();
})
.catch(() => null)
.finally(() => {
setVisible(false);
});
} else {
onClick();
}
};

return (
<React.Fragment>
<Button
qa="new-query-btn"
view="outlined"
size="l"
title="New query"
onClick={handleClick}
>
<Icon awesome="file" size={16} />
New
</Button>
<NewQueryPromt confirm={waiter.resolve} cancel={waiter.reject} visible={visible} />
</React.Fragment>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ const QueryEditorView = React.memo(function QueryEditorView({
<div className={b('actions')}>
<div className="query-run-action">
<Button
qa="qt-run"
className="query-run-action-button"
view="action"
onClick={runQueryCallback}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ export const QuerySettingsButton = ({
className,
onChange,
}: {
className: string;
className?: string;
onChange: (settings: Record<string, string>) => void;
settings?: Record<string, string>;
}) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
align-items: center;

&__control {
margin-right: 8px;
&_name {
display: inline-flex;
align-items: center;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,26 +1,30 @@
import React, {useCallback} from 'react';
import cn from 'bem-cn-lite';
import {Text} from '@gravity-ui/uikit';
import {EditableAsText} from '../../../../components/EditableAsText/EditableAsText';
import {useDispatch, useSelector} from 'react-redux';
import {EditableAsText} from '../../../../components/EditableAsText/EditableAsText';
import {Toolbar} from '../../../../components/WithStickyToolbar/Toolbar/Toolbar';
import {getQuery, getQueryDraft} from '../../module/query/selectors';
import {QuerySettingsButton} from '../../QuerySettingsButton';
import {QueryFilesButton} from '../../QueryFilesButton';
import {updateQueryDraft} from '../../module/query/actions';
import {QueryFile} from '../../module/api';
import {NewQueryButton} from '../../NewQueryButton/NewQueryButton';
import {QueryEngineSelector} from './QueryEngineSelector/QueryEngineSelector';

import './QueryMetaForm.scss';
import {QueryFile} from '../../module/api';

const block = cn('query-tracker-meta-form');
export function QueryMetaForm({
onClickOnNewQueryButton,
className,
cluster,
path,
}: {
className: string;
cluster?: string;
path?: string;
onClickOnNewQueryButton: () => void;
}) {
const dispatch = useDispatch();
const draft = useSelector(getQueryDraft);
Expand All @@ -44,35 +48,66 @@ export function QueryMetaForm({
);

const queryName = draft.annotations?.title;

return (
<div className={block(null, className)}>
<EditableAsText
withControls
className={block('control', {name: true})}
onChange={onNameChange}
text={queryName}
key={originalQuery?.id}
size="l"
>
<Text
title={queryName}
variant="body-1"
color={queryName ? 'primary' : 'secondary'}
ellipsis
>
{queryName || 'No name'}
</Text>
</EditableAsText>
<QueryEngineSelector cluster={cluster} path={path} className={block('control')} />
<QuerySettingsButton
className={block('control')}
settings={draft.settings}
onChange={onSettingsChange}
/>
<QueryFilesButton
files={draft.files}
onChange={onFilesChange}
queryId={originalQuery?.id ?? ''}
<Toolbar
itemsToWrap={[
{
name: 'query-name',
marginRight: 'half',
node: (
<EditableAsText
withControls
className={block('control', {name: true})}
onChange={onNameChange}
text={queryName}
key={originalQuery?.id}
size="l"
>
<Text
title={queryName}
variant="body-1"
color={queryName ? 'primary' : 'secondary'}
ellipsis
>
{queryName || 'No name'}
</Text>
</EditableAsText>
),
},
{
name: 'Engine',
marginRight: 'half',
node: <QueryEngineSelector cluster={cluster} path={path} />,
},
{
name: 'Settings',
marginRight: 'half',
node: (
<QuerySettingsButton
settings={draft.settings}
onChange={onSettingsChange}
/>
),
},
{
name: 'Files',
marginRight: 'half',
node: (
<QueryFilesButton
files={draft.files}
onChange={onFilesChange}
queryId={originalQuery?.id ?? ''}
/>
),
},
{
name: 'NewQuery',
marginRight: 'half',
node: <NewQueryButton onClick={onClickOnNewQueryButton} />,
},
]}
/>
</div>
);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,23 +1,30 @@
import React from 'react';
import cn from 'bem-cn-lite';
import {useSelector} from 'react-redux';
import {useDispatch, useSelector} from 'react-redux';
import {RowWithName} from '../../../containers/AppNavigation/TopRowContent/SectionName';
import {Page} from '../../../../shared/constants/settings';
import {QueryMetaForm} from './QueryMetaForm/QueryMetaForm';

import './index.scss';
import {getQueryGetParams} from '../module/query/selectors';
import {resetQueryTracker} from '../module/query/actions';
import {QueriesListSidebarToggleButton} from '../QueriesListSidebarToggleButton/QueriesListSidebarToggleButton';

import './index.scss';

const block = cn('query-tracker-top-row-content');

export function QueryHeader() {
const dispatch = useDispatch();
const routeParams = useSelector(getQueryGetParams);

const handleClickOnNewQueryButton = () => {
dispatch(resetQueryTracker());
};

return (
<div className={block()}>
<div className={block('meta')}>
<QueryMetaForm
onClickOnNewQueryButton={handleClickOnNewQueryButton}
className={block('meta-form')}
cluster={routeParams.cluster}
path={routeParams.path}
Expand Down
4 changes: 4 additions & 0 deletions packages/ui/src/ui/pages/query-tracker/QueryWidget/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@
justify-content: flex-end;
}

&__meta-form {
margin-right: 12px;
}

.flex-split__pane:nth-child(1) {
overflow: visible;
}
Expand Down
26 changes: 20 additions & 6 deletions packages/ui/src/ui/pages/query-tracker/QueryWidget/index.tsx
Original file line number Diff line number Diff line change
@@ -1,28 +1,42 @@
import React from 'react';
import cn from 'bem-cn-lite';
import QueryEditor from '../QueryEditor/QueryEditor';
import {QueryMetaForm} from '../QueryTrackerTopRow/QueryMetaForm/QueryMetaForm';
import {Button} from '@gravity-ui/uikit';
import {useDispatch, useSelector} from 'react-redux';
import Icon from '../../../components/Icon/Icon';
import {useSelector} from 'react-redux';
import {getCluster} from '../../../store/selectors/global';
import {Button} from '@gravity-ui/uikit';
import {QueryTrackerOpenButton} from '../QueryTrackerOpenButton/QueryTrackerOpenButton';
import {getPath} from '../../../store/selectors/navigation';
import QueryEditor from '../QueryEditor/QueryEditor';
import {QueryMetaForm} from '../QueryTrackerTopRow/QueryMetaForm/QueryMetaForm';
import {QueryTrackerOpenButton} from '../QueryTrackerOpenButton/QueryTrackerOpenButton';
import {QueriesPooling} from '../hooks/QueriesPooling/context';
import {createQueryFromTablePath} from '../module/query/actions';
import {QueryEngine} from '../module/engines';

import './index.scss';

const block = cn('query-widget');

export type QueryWidgetProps = {onClose: () => void};

export default function QueryWidget({onClose}: QueryWidgetProps) {
const dispatch = useDispatch();
const cluster = useSelector(getCluster);
const path = useSelector(getPath);

const handleClickOnNewQueryButton = () => {
dispatch(createQueryFromTablePath(QueryEngine.YQL, cluster, path));
};

return (
<div className={block()}>
<QueriesPooling>
<div className={block('header')}>
<QueryMetaForm className={block('meta-form')} cluster={cluster} path={path} />
<QueryMetaForm
onClickOnNewQueryButton={handleClickOnNewQueryButton}
className={block('meta-form')}
cluster={cluster}
path={path}
/>
<div className={block('header-controls')}>
<div className={block('header-control-left')}>
<QueryTrackerOpenButton
Expand Down
Loading

0 comments on commit 1f4fe1b

Please # to comment.