feat(Navigation): move "permanently delete" checkbox to footer of confirmation modal [YTFRONT-4245] #843
+150
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniil-Pabolkov
force-pushed
the
YTFRONT-4245
branch
from
c139f79
to
51a59e5
Compare
Daniil-Pabolkov
changed the title
Daniil-Pabolkov
force-pushed
the
YTFRONT-4245
branch
from
51a59e5
to
e227ac5
Compare
Daniil-Pabolkov
changed the title
Daniil-Pabolkov
requested review from
ma-efremoff,
evtaranov and
SimbiozizV
as code owners
Daniil-Pabolkov
force-pushed
the
YTFRONT-4245
branch
3 times, most recently
from
f167688
to
70598ef
Compare
ma-efremoff
reviewed
Nov 6, 2024
| const {onFocus} = this.props; | ||
| const {path} = this.state; | ||
|
|
||
| key.setScope('path-editor'); | ||
| this.setState({inputFocus: true}); | ||
| onFocus?.(e, {path}); | ||
| onFocus?.(e, {newPath: path}); |
There was a problem hiding this comment.
Do we really need to replace path with newPath here?
added 4 commits
November 6, 2024 18:38
…int rules [YTFRONT-4245]
…ximum call stack size exceeded" [YTFRONT-4245]
…permanently delete" checkbox is sticky [YTFRONT-4245]
Daniil-Pabolkov
force-pushed
the
YTFRONT-4245
branch
from
70598ef
to
ddff9e6
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nda.ya.ru/t/CoPJ1AlN79Nf8q