Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add kubernetes namespace default placeholder #10

Merged
merged 1 commit into from
May 30, 2023
Merged

Add kubernetes namespace default placeholder #10

merged 1 commit into from
May 30, 2023

Conversation

fpapon
Copy link
Member

@fpapon fpapon commented May 29, 2023

No description provided.

@fpapon fpapon requested a review from rmannibucau May 29, 2023 20:29
rmannibucau
rmannibucau approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@rmannibucau rmannibucau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention in the dox the placeholder uses the globally configured namespace.mvn/clinusers dont know http client class. Otherwise LGTM

@fpapon fpapon requested a review from rmannibucau May 30, 2023 08:51
@fpapon fpapon merged commit a35acbd into yupiik:master May 30, 2023
@fpapon fpapon deleted the namespace branch May 30, 2023 09:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rmannibucau rmannibucau rmannibucau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpapon @rmannibucau