Fix compiler warning (gcc -Wconversion) #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warning: conversion from 'size_t' {aka 'long unsigned int'} to 'int' may change value [-Wconversion]
146 | if (new_parts[i].numeric()) last_numeric_index = i;
Theoretically, it was possible to crash the application when a negative 'last_numeric_index' was set. (when 'new_parts.size() > INT32_MAX')
Also avoids accessing the vector with a signed value using the [] operator.