Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add keep_going keyword argument to IRC #25

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Add keep_going keyword argument to IRC #25

merged 2 commits into from
Jun 19, 2023

Conversation

ehermes
Copy link
Collaborator

@ehermes ehermes commented Jun 19, 2023

This PR does a couple of things:

  1. Adds a keep_going keyword argument to IRC. When keep_going=True, if an IRC inner iteration fails, the IRC optimization will print a warning that the trajectory is no longer accurate, but it will continue with the IRC. This helps when people are using IRC as a way of finding connected minima, but they do not care about the entire IRC trajectory.
  2. Fixes a bug where creating an IRC instance monkey patches the get_W method of the base PES class, resulting in all subsequent optimizations using that same get_W method.
  3. Minor code cleanup and type hinting.

@ehermes ehermes merged commit 723756f into master Jun 19, 2023
@ehermes ehermes deleted the irc_keep_going branch June 19, 2023 19:16
@Andrew-S-Rosen
Copy link
Contributor

Huge thank you for this!!!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants