Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

219 custom get token info #222

Merged
merged 2 commits into from
Jul 5, 2018
Merged

219 custom get token info #222

merged 2 commits into from
Jul 5, 2018

Conversation

bzums
Copy link
Collaborator

@bzums bzums commented Jun 28, 2018

close #219

bzums added 2 commits June 25, 2018 10:07
@bzums
feat(middleware): custom getTokenInfo option
54f2001 
It is now possible to pass an optional `getTokenInfo` implementation to
`authenticationMiddleware` which takes care of the request to the
tokeninfo endpoint, for example to enable measruing reponse times or
configuring the http agent.

close #219
@bzums
test(middleware): add tests for custom impl
157a453 
see #219
@bzums bzums requested review from shuhei, ISO50 and Retro64 June 28, 2018 05:32
@coveralls
Copy link

coveralls commented Jun 28, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 157a453 on 219-custom-get-token-info into e47c422 on master.

@bzums
Copy link
Collaborator Author

bzums commented Jun 28, 2018

👍

2 similar comments
@Retro64
Copy link
Collaborator

Retro64 commented Jun 28, 2018

👍

@shuhei
Copy link
Contributor

shuhei commented Jun 28, 2018

👍

@bzums bzums merged commit 092f2c9 into master Jul 5, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@shuhei shuhei Awaiting requested review from shuhei

@ISO50 ISO50 Awaiting requested review from ISO50

@Retro64 Retro64 Awaiting requested review from Retro64

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom getTokenInfo for authenticationMiddleware
4 participants
@bzums @coveralls @Retro64 @shuhei