Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

feat(layout): provide a way to load extra stylesheets and scripts #25

Closed
rbarilani opened this issue Oct 25, 2017 · 1 comment · Fixed by #52
Closed

feat(layout): provide a way to load extra stylesheets and scripts #25

rbarilani opened this issue Oct 25, 2017 · 1 comment · Fixed by #52
Assignees
@rbarilani
Labels
enhancement
Milestone
0.1.0

Comments

@rbarilani
Copy link
Contributor

rbarilani commented Oct 25, 2017 •
edited
Loading

Provide a way to load extra stylesheets and scripts

Proposal:

_config.yml

theme_config:
   layout_blocks:
      head: 
          - stylesheet:my-custom.css
          - javascript:my-custom.js
     footer:
          - javascript:my-custom-2.js

Proposal 2:

Just give the possibility to add "partials" directly?

theme_config:
   layout:
      head_start: partials/mobile-favicon.ejs # ./source/partials/mobile-favicon.ejs
      head_end: partials/include-custom-styles.ejs
      footer:
          - partials/include-custom-javascript.ejs
          - partials/copyright.ejs
@rbarilani rbarilani self-assigned this Oct 25, 2017
@rbarilani rbarilani mentioned this issue Nov 6, 2017
Merged
@rbarilani
Copy link
Contributor Author

Decide to use the second proposal.

rbarilani added a commit that referenced this issue Nov 15, 2017
@rbarilani
fix(logo-text): long logo text breaks layout
a7bcb30 
closes #25
@rbarilani rbarilani mentioned this issue Nov 15, 2017
Merged
@rbarilani rbarilani added this to the 0.1.0 milestone Nov 15, 2017
rbarilani added a commit that referenced this issue Nov 16, 2017
@rbarilani
feat(project-partial): add new feature
a98c6dd 
test(project-partial): add more unit test
	* Try using golang table testing approach
	* coverage 100%

docs(project-partials): update comments

close #25
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@rbarilani rbarilani

Labels
enhancement
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

feat(project-partial): add new feature zalando-incubator/hexo-theme-doc
1 participant
@rbarilani