Skip to content
This repository was archived by the owner on Sep 21, 2021. It is now read-only.

Filter by active sessions #1004

Merged

Conversation

jlamaille
Copy link
Contributor

Description

Added a filter on the Live View servlet to display only active sessions.

Motivation and Context

In a continuous deployment chain context, we deploy GRIDs with many probes.
As a result, the display of the live view is strongly slowed down by multiple VNC connections.
But when we want to debug on executions in progress in our chain,
we only need active sessions.

How Has This Been Tested?

I have tested each filtering case to true, false, and unspecified

My modification has an impact on the servlet of the live view.

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the ** CONTRIBUTING ** document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Jul 15, 2019

Codecov Report

Merging #1004 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #1004      +/-   ##
============================================
+ Coverage     54.97%   54.99%   +0.02%     
  Complexity      675      675              
============================================
  Files            58       58              
  Lines          4557     4562       +5     
  Branches        428      429       +1     
============================================
+ Hits           2505     2509       +4     
  Misses         1818     1818              
- Partials        234      235       +1

Copy link
Contributor

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @jlamaille!

@diemol diemol merged commit 5df8346 into zalando:master Jul 19, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants