Skip to content
This repository was archived by the owner on Sep 21, 2021. It is now read-only.

added fix to role_binding.yaml file in the templates folder. #697

Merged
merged 1 commit into from Aug 15, 2018
Merged

added fix to role_binding.yaml file in the templates folder. #697

merged 1 commit into from Aug 15, 2018

Conversation

CatCassie
Copy link

@CatCassie CatCassie commented Aug 15, 2018

… release name

Thanks for contributing to Zalenium! Please give us as much information as possible to merge this PR
quickly.

Description

Motivation and Context

To fix Error: render error in "zalenium/templates/role-binding.yaml": template: zalenium/templates/role-binding.yaml:14:20: executing "zalenium/templates/role-binding.yaml" at <{{template "fullname...>: template "fullname" not defined while installing zalenium helm chart with role binding enabled.

How Has This Been Tested?

Re-ran helm install command and this error was gone.

A ubuntu virtual machine with helm and kubectl installed and a kubenetes cluster available for helm and kubectl.

It will not have impact in other areas of the code, this is to reference the correct definition: "zalenium.fullname" which was defined in the _helper.tpl file.

Types of changes

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.

@ecktom
Copy link
Contributor

ecktom commented Aug 15, 2018

Correct... My bad, I missed this line in #693

@codecov-io
Copy link

Codecov Report

Merging #697 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #697      +/-   ##
============================================
- Coverage     62.24%   62.18%   -0.07%     
  Complexity      516      516              
============================================
  Files            45       45              
  Lines          3255     3255              
  Branches        283      283              
============================================
- Hits           2026     2024       -2     
- Misses         1036     1038       +2     
  Partials        193      193

@diemol
Copy link
Contributor

diemol commented Aug 15, 2018

Thanks @CatCassie!

@diemol diemol merged commit 07c9d01 into zalando:master Aug 15, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
4 participants