feat: modernize setup project #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qtdan
reviewed
May 12, 2023
There was a problem hiding this comment.
Thanks for the PR.
Please also help to update contribution guide about your changes
I just updated the setup configuration, don't change the way to contribute. What information do you want me to update? |
|
longxice
reviewed
May 15, 2023
longxice
reviewed
May 15, 2023
huuduy005
force-pushed
the
feature/modernize-setup
branch
from
cdb3b5f
to
be401b0
Compare
|
@longxice please resolve your comment |
|
LGTM |
|
LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem you’re solving
This PR tries to modernize the setup project and improve process build.
Hope to improve our Developer Experience.
Any tests you wrote
No update. I just updated the setup config.
Changes: