Update tfhe and tkms #126
Merged
Update tfhe and tkms #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanBredehoft
approved these changes
Nov 7, 2024
|
Can you increment the version of the package in the PR? |
immortal-tofu
approved these changes
Nov 7, 2024
|
I'll merge and handle prerelease. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hope to release a new kms RC (maybe rc24) that uses the 0.9 tfhe-rs with, and update the L1 demo to use the new RC from kms that has a working keyurl. So ideally we need a fhevmjs with 0.9.1 tfhe-rs (0.9.0 is broken on the js side).
@immortal-tofu could you also trigger a pre release after this PR is in?