Avoid leak when stopping server #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If accept fails, e.g., because the server is no longer listening the connection object is not terminated and it results in a memory leak: connection -> handler -> connection.
zaphoyd
added a commit
that referenced
this pull request
Mar 4, 2014
Avoid leak when stopping server
zaphoyd
added a commit
that referenced
this pull request
Mar 4, 2014
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If accept fails, e.g., because the server is no longer listening the
connection object is not terminated and it results in a memory leak:
connection -> handler -> connection.
Note: terminating connections that are not "accepted" results in asio error 10009 (invalid socket), since the OS socket is not created until accept succeeds. While this error appears to be harmless con->terminate() probably needs to be reworked to avoid generating a spurious log warning.
In addition, during stop, the endpoint goes through the accept loop one time too many: stop_listening() results in the current accept to fail with operation_cancelled, but then handle_accept calls accept_async unconditionally. In this case the call to accept_async is not necessary.
Thanks,
--aydan