Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix compiler warnings for clang/c++11 #358

Closed
wants to merge 1 commit into from
Closed

fix compiler warnings for clang/c++11 #358

wants to merge 1 commit into from

Conversation

logotype
Copy link

  • cast numbers to correct type
  • prefix ntohll/htonll to websocketpp_ntohll due to builtin function

@zaphoyd
Copy link
Owner

zaphoyd commented Jun 29, 2014

The websocket++ bundled ntohll is already prefixed with a namespace to avoid this sort of collision. Would explicitly calling fully qualified websocketpp::lib::ntohll rather than just ntohll in the library to avoid an ambiguous lookup fix your warning/error messages?

zaphoyd pushed a commit that referenced this pull request Oct 14, 2014
prefix htonll/ntohll fixes #381 fixes #382 references #358
2e7a902 
This avoids conflicts with OS level macros
zaphoyd pushed a commit that referenced this pull request Oct 15, 2014
Update base64_encode length parameter to more sane type references #358
83a66f4 
Also adds documentation and cleans up formatting
zaphoyd pushed a commit that referenced this pull request Oct 15, 2014
Update sha1::calc length parameter to more sane type references #358
9807283 
also cleans up formatting and code style and adds documentation
jim-wong pushed a commit to yoinc/websocketpp that referenced this pull request Oct 21, 2014
@jim-wong
prefix htonll/ntohll fixes zaphoyd#381 fixes zaphoyd#382 references z…
f46c586 
…aphoyd#358

This avoids conflicts with OS level macros

Conflicts:
	changelog.md
	test/utility/frame.cpp
@zaphoyd
Copy link
Owner

zaphoyd commented Feb 4, 2016

Closing this as all of these issues have been addressed on the develop branch

@zaphoyd zaphoyd closed this Feb 4, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@logotype @zaphoyd