Fix dangling pointer and message in error.hpp. #432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two little problems still in this file.
what()
returns aconst char*
that comes from astd::string
. If thestd::string
changes, theconst char*
might become invalid, resulting in undefined behavior.exception
are inconsistent. In the first one, if there's no message the message from the error code is used. In the second one, there's no message, even though there's an error code provided.My solution to the first problem was simply to make that one
std::string
memberconst
. It will break any code that changes them_msg
on anexception
- but if they did that, they were flirting with UB anyway - and everything else should work unchanged.