Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cmake examples/tests fix #449

Merged
merged 3 commits into from
Jul 29, 2015
Merged

Cmake examples/tests fix #449

merged 3 commits into from
Jul 29, 2015

Conversation

thoys
Copy link
Contributor

@thoys thoys commented Jul 16, 2015

Added CMake Files to the tests, also added CMake files where they were missing.
Should fix #378

Also added USE_FOLDERS property to CMake and a folder property to each CMake file, that would organize the project this way:
folders

thoys added 3 commits July 16, 2015 11:38
… and example directories using the global variable USE_FOLDERS
@zaphoyd zaphoyd merged commit bc7ad65 into zaphoyd:develop Jul 29, 2015
@zaphoyd
Copy link
Owner

zaphoyd commented Jul 29, 2015

Thanks for this pull request. I've made a few modifications (mostly fixing the way the tests were set up, flagging more programs as needing OpenSSL, and added zlib detection and use for the tests/examples that use the new permessage-deflate extension) and merged it.

I have one other thing on the CMake wishlist that I'm not entirely sure where to start, perhaps you have an idea. I'd like a way to run all compiled programs flagged as tests. A make test basically that builds and runs all tests. What is the best way to go about adding something like that? Is that something that CMake can express naturally? or would it be best to just write a shell script that loops over bin/test_* and runs?

@thoys
Copy link
Contributor Author

thoys commented Jul 30, 2015

hey @zaphoyd , I am not very experienced with CMake yet, but I could have a look at http://www.cmake.org/Wiki/CMake/Testing_With_CTest and try to apply it. It says it has support for make test.

@thoys thoys deleted the cmake-tests-fix branch July 30, 2015 12:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants