Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Try to fix issue #599 with an untested patch #600

Closed
wants to merge 1 commit into from

Conversation

LocutusOfBorg
Copy link
Contributor

This might fix issue #599, but I have no clues about what does it mean

@kroeckx
Copy link

kroeckx commented Nov 2, 2016

So looking at SSL_R_SHORT_READ it was only used in SSLv2, and it seems related to requesting certificates. I suggest you just remove the whole if and just:
return make_error_code(transport::error::pass_through);

@LocutusOfBorg
Copy link
Contributor Author

updated thanks!

@kroeckx
Copy link

kroeckx commented Nov 2, 2016

Hmm, I might have suggested to remove too much, maybe you do want to return that it's a tls error.

@LocutusOfBorg
Copy link
Contributor Author

this way?

@kroeckx
Copy link

kroeckx commented Nov 3, 2016

Yes, looks good.

@8W9aG
Copy link

8W9aG commented Mar 8, 2017

Would it be possible to get this patch in? It's currently blocking me as well

@zaphoyd
Copy link
Owner

zaphoyd commented Jun 11, 2017

A fix for this in theory has been committed to develop branch.

@LocutusOfBorg
Copy link
Contributor Author

closing thanks!

@abitmore
Copy link

abitmore commented Feb 14, 2018

A fix for this in theory has been committed to develop branch.

@zaphoyd may I ask which commit is it? Thanks.

//Update: found it: 16d126e

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants